Try to change color of magnifier icon #3708
Conversation
koppor
changed the title
| @@ -13,7 +15,21 @@ | |||
| public static TextField create() { | |||
| CustomTextField textField = (CustomTextField) TextFields.createClearableTextField(); | |||
| textField.setPromptText(Localization.lang("Search") + "..."); | |||
| textField.setLeft(IconTheme.JabRefIcon.SEARCH.getGraphicNode()); | |||
| Node node = IconTheme.JabRefIcon.SEARCH.getGraphicNode(); | |||
| node.setStyle("-fx-text-fill: #00ffff"); | |||
There was a problem hiding this comment.
-fx-fill should work, but do you really think that changing the icon color is a good idea? How intuitive (and important) is it to signal an advanced search mode by magenta?
The "right" way to change the style depending on the state in javafx are pseudo classes (so you can decouple the view from the style), see e.g. http://www.guigarage.com/2016/02/javafx-and-css-pseudo-classes/
There was a problem hiding this comment.
Unfortunately, fx-fill doesn't help. There seems to be a deeper problem with exactly this icon.
Actually, I am quite indifferent to this, but @koppor really wants it.
There was a problem hiding this comment.
I really like the proposal at #3535 (comment). However, JabRef had this functionality for at least one year. Animation at #3535 (comment). - Simon and I had a long discussion on that. The decision was that we should present to the user that there are different search modes. They should "just work", but for the pros, there should be a hint which mode is active. Not that someone wonders why the search does not work. -- Furthermore, that icon makes it less hard to debug the search. It is clear, whether the search term is a grammar-based search or just plain text string search.
There was a problem hiding this comment.
ok, I see your point. It is just again a feature that needs documentation before anybody understands what's going it.
Butt if fx-fill and fx-text-fill don't work, I'm running out of ideas. I usually use a combination out of both and it worked without any problems so far. Maybe it works if you base this PR on the maintable-beta branch. I changed a few things regarding javafx icons there.
There was a problem hiding this comment.
I have tried some more (not the maintable branch, though) with no success. I think this is down to CustomTextField from controls-fx. It offers the functionality to add a node at the left or right side, but it seems to be impossible to change the style of this node.
Because of this, I've gone back to the previous version: A Swing icon next to the text field and everything just works. I know this is a step back, but if the CustomTextField cannot be made to use our icon theme, then we should probably migrate the whole GlobalSearchBar to JavaFX instead. Until this happens, I think it is wiser to use icons that preserve our color theme.
@tobiasdiez @koppor: I'll now leave it open to you to continue arguing, merge, or close this PR. I am fine with any solution.
lenhard
changed the title
lenhard
added
the
status: ready-for-review
|
Screenshot: There is a space between the other icons. Until the cool solution from #3535 (comment) is implemented, I am in favor of using this approach. Reason: This makes the JabRef feature explicit.
|
|
Well, if @koppor really wants this I'm fine with it although I bet that more users get confused by a cyan-highlighted icon than they are getting enlighted by it. |
I am trying to change the color of the magnifier icon as requested here: #3535
However, the icon refuses a color change. It even opts out of the color scheme of JabRef, since it is black instead of purple (despite the fact that the icon is configured as purple in the code).
@tobiasdiez How can I change the color of this icon? Any change will do, really. For reasons unknown to me the icon straight-out refuses the change.